Skip to content

bpo-34018: Doc'd that type names of SQLite converters are case-insensitive. #8042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 1 commit into from
Jul 3, 2018
Merged

bpo-34018: Doc'd that type names of SQLite converters are case-insensitive. #8042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/library/sqlite3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ Module functions and constants
Registers a callable to convert a bytestring from the database into a custom
Python type. The callable will be invoked for all database values that are of
the type *typename*. Confer the parameter *detect_types* of the :func:`connect`
function for how the type detection works. Note that the case of *typename* and
the name of the type in your query must match!
function for how the type detection works. Note that *typename* and the name of
the type in your query are matched in case-insensitive manner.

@taleinat taleinat Jul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain the "must match" wording, e.g.: "... must match (case-insensitively)!"

@sir-sigurd sir-sigurd Jul 3, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO "must match" wording was about their case and that they "must match" is already contained in The callable will be invoked for all database values that are of the type *typename*., so we need only to state that these types are compared in case-insensitive manner.

@taleinat taleinat Jul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon re-reading, you're right!



.. function:: register_adapter(type, callable)
Expand Down