Skip to content

Fix markup for xml.sax in 3.8 notes - #9603

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
andresdelfino:patch-1
Nov 7, 2018
Merged

Fix markup for xml.sax in 3.8 notes#9603
serhiy-storchaka merged 2 commits into
python:masterfrom
andresdelfino:patch-1

Conversation

@andresdelfino

Copy link
Copy Markdown
Contributor

No description provided.

@serhiy-storchaka

Copy link
Copy Markdown
Member

What does this do in the "What's New" document? If this is a bugfix, it shouldn't be added here. If this is a new feature, it should not be backported.

@andresdelfino

Copy link
Copy Markdown
Contributor Author

What does this do in the "What's New" document? If this is a bugfix, it shouldn't be added here. If this is a new feature, it should not be backported.

Perhaps it was meant for 3.8 at first but then it was decided to be backported? Maybe we should just remove the mention about this altogether in 3.8?

@tiran

tiran commented Sep 28, 2018

Copy link
Copy Markdown
Member

It's a possibly breaking change and therefore has to be documented in whatsnew. Two core devs wanted to have the changed documented in whatsnews. I agreed with their wish, too.

@andresdelfino

andresdelfino commented Oct 29, 2018

Copy link
Copy Markdown
Contributor Author

@tiran Is it custom to add a What's new entry in an upcoming major version when the change will be provided before in a maintenance release of a stable version? This fix was already made available in 3.7.1 and we are announcing it again in 3.8, like the bug was still there in 3.7.X. Also note that the documentation changes of this fix for 3.8 say the change was made in 3.8, but, again, the fix was made in 3.7.1. Seems confusing.

IMHO, What's new in {master} should be a delta against the the latest stable release.

If this sounds reasonable I can make a PR with the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants