Skip to content

Remove some python2 left-overs#13340

Merged
sobolevn merged 2 commits into
python:masterfrom
sobolevn:remove-python2-leftovers
Aug 6, 2022
Merged

Remove some python2 left-overs#13340
sobolevn merged 2 commits into
python:masterfrom
sobolevn:remove-python2-leftovers

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 6, 2022

Copy link
Copy Markdown
Member

No description provided.

@sobolevn sobolevn requested a review from hauntsaninja August 6, 2022 06:40
Comment thread misc/dump-ast.py
parser = argparse.ArgumentParser(
description="Parse source files and print the abstract syntax tree (AST)."
)
parser.add_argument("--py2", action="store_true", help="parse FILEs as Python 2")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is our internal tool, so we can remove this option, end users are not affected.

[out]

[case testFunctionalEnum_python2-skip]
[case testFunctionalEnum]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it does not hurt to keep this test.

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

github-actions Bot commented Aug 6, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn sobolevn merged commit 48ae9d5 into python:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants