Tutorial Classes Review. #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @christopheNan, your editor re-indented all msgids, which make the diff unreadable. As anyone is free to use the editor and configuration of their choice, I created https://pypi.python.org/pypi/poindent so anyone can reindent right before pushing, allowing us to use all the exact same line-breaking rules, highly reducing the diffing lines. It would be great if after fixing the wrapping you could amend your commit instead of commiting a new, to reduce the ping-pong of line break in history. |
Indentation Fixed with poindent.
christopheNan
force-pushed
the
tutoclasses
branch
from
a2e7f47 to
4b2dcdf
Compare
|
I reindented with poindent. |
|
I will create a new PR. |
|
Manually merged. |
JulienPalard
pushed a commit
that referenced
this pull request
Jul 13, 2023
Co-authored-by: Christophe Nanteuil <christophe.nanteuil@gmail.com> Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/152 Reviewed-by: Julien Palard <julien@palard.fr> Co-authored-by: Christophe Nanteuil <christophenan@noreply.localhost> Co-committed-by: Christophe Nanteuil <christophenan@noreply.localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.