gh-38: Update update_switcher_chart with title and line plot #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
changed the title
m-aciek
reviewed
Nov 27, 2024
Collaborator
m-aciek
left a comment
m-aciek
left a comment
There was a problem hiding this comment.
I suggest minor improvements
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Member
Author
|
All good! |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my ideas in #38 In my opinion a line plot looks much clearer and easier to read. We should also look into updating the code as the plot_date function was deprecated in Matplotlib 3.9 and will be removed in 3.11.
Closes #38.