Skip to content

update generate_pep_pages to support the new PEP 0(rst format) #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 1 commit into from
Jun 7, 2018
Merged

update generate_pep_pages to support the new PEP 0(rst format) #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 9 additions & 40 deletions peps/converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,36 +34,8 @@ def convert_pep0():
"""
pep0_path = os.path.join(settings.PEP_REPO_PATH, 'pep-0000.html')
pep0_content = open(pep0_path).read()

soup = BeautifulSoup(pep0_content, 'lxml')

body_children = list(soup.body.children)

# Grab header and PEP body
header = body_children[3]
pep_content = body_children[7]

# Fix PEP links
body_links = pep_content.find_all("a")

pep_href_re = re.compile(r'pep-(\d+)\.html')

for b in body_links:
m = pep_href_re.search(b.attrs['href'])

# Skip anything not matching 'pep-XXXX.html'
if not m:
continue

b.attrs['href'] = '/dev/peps/pep-{}/'.format(m.group(1))

# Remove Version from header
header_rows = header.find_all('th')
for t in header_rows:
if 'Version:' in t.text and 'N/A' in t.next_sibling.text:
t.parent.extract()

return ''.join([str(header), str(pep_content)])
data = convert_pep_page(0, pep0_content)
return data['content']


def get_pep0_page(commit=True):
Expand Down Expand Up @@ -180,16 +152,6 @@ def convert_pep_page(pep_number, content):
pep_content.body.unwrap()

data['content'] = str(pep_content)

pep_ext = '.txt'
pep_rst_source = os.path.join(settings.PEP_REPO_PATH,
'pep-{}.rst'.format(pep_number))
if os.path.exists(pep_rst_source):
pep_ext = '.rst'

source_link = 'https://github.com/python/peps/blob/master/pep-{}{}'.format(
pep_number, pep_ext)
data['content'] += """Source: <a href="{0}">{0}</a>""".format(source_link)
return data


Expand All @@ -204,6 +166,13 @@ def get_pep_page(pep_number, commit=True):
return

pep_content = convert_pep_page(pep_number, open(pep_path).read())
pep_rst_source = os.path.join(
settings.PEP_REPO_PATH, 'pep-{}.rst'.format(pep_number),
)
pep_ext = '.rst' if os.path.exists(pep_rst_source) else '.txt'
source_link = 'https://github.com/python/peps/blob/master/pep-{}{}'.format(
pep_number, pep_ext)
pep_content['content'] += """Source: <a href="{0}">{0}</a>""".format(source_link)

pep_page, _ = Page.objects.get_or_create(path=pep_url(pep_number))

Expand Down