Change parameters order to avoid YUI Compressor bug #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code lead to an invalid value for the left property: `left: calc(-50vw+50%);` This was being caused due to a bug in YUI Compressor. You can read a detailed explanation about it in this issue: yui/yuicompressor#59 This is fixed since version 2.4.9-BSI-2. But, until we don't update prod's YUI Compressor, this PR work as a bugfix since it changes the parameters order to one properly understood by the bugged version. More aboute this in this issue comment: yui/yuicompressor#59 (comment)
ewdurbin
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code lead to an invalid value for the left property:
left: calc(-50vw+50%);This was being caused due to a bug in YUI Compressor (used by Django pipeline).
You can read a detailed explanation about it in this issue:
yui/yuicompressor#59
This is fixed since version 2.4.9-BSI-2. But, until we don't update
prod's YUI Compressor, this PR work as a bugfix since it changes the
parameters order to one properly understood by the bugged version.
More aboute this in this issue comment:
yui/yuicompressor#59 (comment)