Fix PSF membership link (#2787) with dynamic logic #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
czc0407
force-pushed
the
fix-psfmember-link
branch
from
3504be8 to
df18302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2766 — Clicking the PSF membership link previously led to
/users/membership/edit/,causing a 404 for unauthenticated users. This PR updates the link rendering logic and adds tests.
Changes
templates/includes/authenticated.htmlto dynamically choose:/users/membership/for non-members/users/membership/edit/for existing membersusers/tests/test_membership_links.pyTesting
Run:
python3 manage.py test users.tests.test_membership_linksAll tests passed ✅
Impact
This fix ensures the membership link works for both logged-in and anonymous users.