Remove unnecessary = ...s; bump pyright test dependency to 1.1.301#9972
Merged
srittau merged 5 commits intopython:mainfrom Mar 29, 2023
Merged
Remove unnecessary = ...s; bump pyright test dependency to 1.1.301#9972srittau merged 5 commits intopython:mainfrom
= ...s; bump pyright test dependency to 1.1.301#9972srittau merged 5 commits intopython:mainfrom
Conversation
AlexWaygood
changed the title
AlexWaygood
changed the title
= ...s; bump pyright test dependency to 1.1.300
AlexWaygood
changed the title
= ...s; bump pyright test dependency to 1.1.300= ...s; bump pyright test dependency to 1.1.301
AlexWaygood
commented
Mar 29, 2023
Comment on lines
+8
to
+20
| BLACK: ClassVar[int] | ||
| BLUE: ClassVar[int] | ||
| GREEN: ClassVar[int] | ||
| CYAN: ClassVar[int] | ||
| RED: ClassVar[int] | ||
| MAGENTA: ClassVar[int] | ||
| YELLOW: ClassVar[int] | ||
| GREY: ClassVar[int] | ||
|
|
||
| class WinStyle: | ||
| NORMAL: int = ... | ||
| BRIGHT: int = ... | ||
| BRIGHT_BACKGROUND: int = ... | ||
| NORMAL: ClassVar[int] | ||
| BRIGHT: ClassVar[int] | ||
| BRIGHT_BACKGROUND: ClassVar[int] |
Member
Author
There was a problem hiding this comment.
These all look like they could probably be Final (source code here: https://github.com/tartley/colorama/blob/master/colorama/winterm.py), but that could cause false-positive errors if I'm incorrect about that, and I'm not confident enough to risk it
Member
There was a problem hiding this comment.
Seems pretty clear these should be final. They're primitive enums.
srittau
approved these changes
Mar 29, 2023
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a lot of new errors; I'm opening a draft PR so that we can see exactly what they are and analyze/fix them where possible. Some may be bugs in pyright rather than typeshed.