Skip to content

Remove unnecessary = ...s; bump pyright test dependency to 1.1.301 #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 5 commits into from
Mar 29, 2023
Merged

Remove unnecessary = ...s; bump pyright test dependency to 1.1.301 #9972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df9c706
Bump pyright to 1.1.300
AlexWaygood Mar 28, 2023
8ba3a25
Merge branch 'main' into pyright-1.1.300
srittau Mar 29, 2023
ae96a4b
Fix one that Sebastian missed in #9976
AlexWaygood Mar 29, 2023
576167d
more
AlexWaygood Mar 29, 2023
d05ae6b
1.1.301 was released yesterday
AlexWaygood Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ all = true
disable_all_dunder_policy = true

[tool.typeshed]
pyright_version = "1.1.299"
pyright_version = "1.1.301"
2 changes: 1 addition & 1 deletion stdlib/typing_extensions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ if sys.version_info >= (3, 11):
)
else:
Self: _SpecialForm
Never: _SpecialForm = ...
Never: _SpecialForm
def reveal_type(__obj: _T) -> _T: ...
def assert_never(__arg: Never) -> Never: ...
def assert_type(__val: _T, __typ: Any) -> _T: ...
Expand Down
23 changes: 12 additions & 11 deletions stubs/colorama/colorama/winterm.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
import sys
from typing import ClassVar

if sys.platform == "win32":
from . import win32

class WinColor:
BLACK: int = ...
BLUE: int = ...
GREEN: int = ...
CYAN: int = ...
RED: int = ...
MAGENTA: int = ...
YELLOW: int = ...
GREY: int = ...
BLACK: ClassVar[int]
BLUE: ClassVar[int]
GREEN: ClassVar[int]
CYAN: ClassVar[int]
RED: ClassVar[int]
MAGENTA: ClassVar[int]
YELLOW: ClassVar[int]
GREY: ClassVar[int]

class WinStyle:
NORMAL: int = ...
BRIGHT: int = ...
BRIGHT_BACKGROUND: int = ...
NORMAL: ClassVar[int]
BRIGHT: ClassVar[int]
BRIGHT_BACKGROUND: ClassVar[int]
Comment on lines +8 to +20
Copy link
Member Author

@AlexWaygood AlexWaygood Mar 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look like they could probably be Final (source code here: https://github.com/tartley/colorama/blob/master/colorama/winterm.py), but that could cause false-positive errors if I'm incorrect about that, and I'm not confident enough to risk it

Copy link
Member

@JelleZijlstra JelleZijlstra Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty clear these should be final. They're primitive enums.


class WinTerm:
def __init__(self) -> None: ...
Expand Down