Partial fix for #1111: replace some draw_text calls#1240
Merged
einarf merged 1 commit intopythonarcade:developmentfrom Jun 17, 2022
Merged
Partial fix for #1111: replace some draw_text calls#1240einarf merged 1 commit intopythonarcade:developmentfrom
einarf merged 1 commit intopythonarcade:developmentfrom
Conversation
pushfoo
force-pushed
the
partial_text_object_promotion
branch
from
624634d to
9242f76
Compare
* Sprite Collect Coins: Replace draw_text and .center_* with Text and .position * Acceleration and Friction: Replace draw_text and .center_* with Text and .position * Game Controller/Joystick: Replace .center_* in initialization with .position
pushfoo
force-pushed
the
partial_text_object_promotion
branch
from
9242f76 to
8f18833
Compare
Member
|
Looks reasonable. A lot of stuff that needs cleanup in examples. I have done a few passes already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built locally and viewed in browser. Includes tweaks to highlighted line numbers.
Let me know if the vertical slice of changes here is acceptable. If it is, I'll keep working on #1111.
Changes made:
arcade.draw_textand.center_* witharcade.Textand.positionarcade.draw_textand.center_* witharcade.Textand.position.center_* in initialization with.position