Improve keyboard modifier & event doc#1242
Merged
einarf merged 1 commit intopythonarcade:developmentfrom Jun 20, 2022
Merged
Conversation
* Rewrite Working with the Keyboard to include concept of active modifiers * Fix misleading keyboard modifier phrasing in application.py to use active instead of held * Make keyboard event doc consistent with mouse event doc in Window * Add links to examples of handling keyboard events to Working with the Keyboard * Add links to doc for arcade.key module containing constants * Fix some awkward phrasing in open_window docstring
pushfoo
force-pushed
the
improve_keyboard_event_doc
branch
from
08d13a6 to
c973ae8
Compare
pushfoo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to pyglet/pyglet#629. Prior to this PR, our keyboard modifier doc was a copy of the pyglet's. I significantly expanded it to hold the reader's hand because middle and highschool students are one of our target demographics.
Built & tested locally.
Summary of changes: