Optimization & bug fixes for PerfGraph#1265
Merged
einarf merged 56 commits intopythonarcade:developmentfrom Jul 30, 2022
Merged
Optimization & bug fixes for PerfGraph#1265einarf merged 56 commits intopythonarcade:developmentfrom
einarf merged 56 commits intopythonarcade:developmentfrom
Conversation
pushfoo
force-pushed
the
optimize_perf_graph
branch
from
fea3cd9 to
559826e
Compare
pushfoo
changed the title
pushfoo
force-pushed
the
optimize_perf_graph
branch
from
1d33db0 to
b986e8b
Compare
pushfoo
changed the title
Member
|
Let's just merge this. It will be be first feature using pyglet batches in arcade 👍 (Since this is now possible in 2.7) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr ~7% faster, fixes bugs, backward compatible
These changes seem to run at least 7% faster and with far more FPS stability than the current development branch. Most of the improvement is likely from the removal of
arcade.draw_text.Major changes:
arcade.Textinstances instead ofarcade.draw_textcallspyglet.graphics.Lineinstances for non-data linesPerformance comparison:
These screen shots are toward the maximum improvement (52 FPS is the minimum on development for my system). 7% improvement seems to be the average. Getting exact numbers doesn't seem worth the time at the moment, but the improved FPS stability of the PR version is worth noting.
Before:
After: