Use stronger typing for buffer protocol objects in gl module#1293
Merged
einarf merged 15 commits intopythonarcade:developmentfrom Aug 2, 2022
Merged
Conversation
…mber of objects that support it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1227 and goes beyond the initial ticket. There were multiple places with weak or absent typing worth improving. There's also a new programming guide section that is linked from the docstrings of the more commonly used objects.
Since GL objects have subtle differences in
writebehavior, there are two union types:BufferProtocolas a top-level arcade type to cover general casesBufferOrBufferProtocolingl.typesfor cases where agl.Bufferis also acceptable.