Clarify SpriteSolidColor and SpriteCircle docstrings#1319
Merged
einarf merged 1 commit intopythonarcade:developmentfrom Sep 9, 2022
Merged
Clarify SpriteSolidColor and SpriteCircle docstrings#1319einarf merged 1 commit intopythonarcade:developmentfrom
einarf merged 1 commit intopythonarcade:developmentfrom
Conversation
Member
|
I'll just merge this. We can update when we change it to only make white textures. |
Member
Author
|
@einarf I think we might want to set color to a keyword arg to get the best of both worlds. |
Member
|
Should not be a problem. Default white then? |
Member
Author
|
Yes, for both of them. I'd also like to take consider changing some of the related underlying functionality after I finish my current experiment and reflect on it for a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built & tested locally.
This PR clarifies the
SpriteSolidColorandSpriteCircledocstrings by making the following changes:SpriteCircle