Update pymunk_physics_engine.py#1322
Merged
pvcraven merged 1 commit intopythonarcade:developmentfrom Sep 17, 2022
Merged
Conversation
Per pymunk documentation, the pre handler is supposed to return a bool
Member
|
This might be worth backporting to 2.6.X if we plan to do another release in that branch |
pushfoo
approved these changes
Sep 17, 2022
Member
pushfoo
left a comment
pushfoo
left a comment
There was a problem hiding this comment.
It looks good to me & works locally. I can't merge it myself, but einarf or Clepto might get to it later tonight.
Member
|
@pvcraven can you look at this? |
pvcraven
pushed a commit
that referenced
this pull request
Sep 24, 2022
Per pymunk documentation, the pre handler is supposed to return a bool (cherry picked from commit 5a69eac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per pymunk documentation, the pre handler is supposed to return a bool:
"Return false from the callback to make pymunk ignore the collision this step or true to process it normally. Additionally, you may override collision values using Arbiter.friction, Arbiter.elasticity or Arbiter.surfaceVelocity to provide custom friction, elasticity, or surface velocity values. See Arbiter for more info."
This addresses the error which occurs if you define a pre_handler function for collisions without this fix.:
"UserWarning: Function '_f3' should return a bool to indicate if the collision should be processed or not when used as 'begin' or 'pre_solve' collision callback.
def _f3(arbiter, space, data):"