General Code Refactor Using Sourcery#1326
Merged
pvcraven merged 6 commits intopythonarcade:developmentfrom Sep 24, 2022
BrettskiPy:1325-general-refactor
Merged
General Code Refactor Using Sourcery#1326pvcraven merged 6 commits intopythonarcade:developmentfrom BrettskiPy:1325-general-refactor
pvcraven merged 6 commits intopythonarcade:developmentfrom
BrettskiPy:1325-general-refactor
Conversation
Initial refactor
added additional refactoring
Added extra line
added mistakenly removed comment and added visual space
Removed extra lines and unneeded comments
BrettskiPy
commented
Sep 19, 2022
BrettskiPy
changed the title
pvcraven
requested changes
Sep 22, 2022
Member
pvcraven
left a comment
pvcraven
left a comment
There was a problem hiding this comment.
There are some good refactors here. Not super-wild about all the ternary usage. Some is ok when the code is short, but I think it makes things hard to read.
Member
|
I did another pass-through. I think if you update with the changes, I'm happy to merge in. |
Reverted code based on PR feedback
pvcraven
approved these changes
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1325
I've noticed a few areas of the Arcade codebase that can be improved with the assistance of AI refactoring tools Sourcery. I spent some time to pick out a subsection of the ways I believe the code can be improved.
If any/all of these "suggestions" are implemented, I'll be happy. The AI refactoring selections I've chosen are my bias to what "cleaner code" is. There are plenty more suggestions, but I figured I would start with this to see if this is something that is received positively. 😉
Thank you!