Add general NinePatchTexture support within all UIWidgets#1358
Merged
eruvanos merged 2 commits intodevelopmentfrom Oct 24, 2022
Merged
Add general NinePatchTexture support within all UIWidgets#1358eruvanos merged 2 commits intodevelopmentfrom
eruvanos merged 2 commits intodevelopmentfrom
Conversation
Member
|
Looks fine. I would like to have the old If that didn't work before these changes we can fix that after merge. |
einarf
approved these changes
Oct 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@einarf This removes the position and draw_size from the NinePatchTexture.
Right now the shader code does not allow to set some draw position, which is not a dealbreaker due to the scissor box used while rendering each widget.
Anything we should change before merging?