Sections improvements#1364
Merged
einarf merged 8 commits intopythonarcade:developmentfrom Oct 27, 2022
Merged
Conversation
added 8 commits
October 27, 2022 14:35
Section breaking change param renamed accept_keyboard_keys Fix event return type to pyglet standard EVENT_HANDLED / EVENT_UNHANDLED Section init docstrings added Section typing improvements Window.show_view will not push view handlers if empty View.section_manager is now lazily instantiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few improvements and fixes to Sections:
accept_mouse_eventsto allow a section to accept certain mouse events if anyaccept_keyboard_eventsrenamed toaccept_keyboard_keysEVENT_HANDLED/EVENT_UNHANDLEDWindow.show_viewwill only push the handlers if they are not emptyView.section_manageris now lazily instantiatedView.on_draw,View.on_updateandView.on_resizeto be called after the section corresponding methods or not being call at all.