Merged
Conversation
added 3 commits
November 4, 2022 23:17
Section.draw_order can now be smaller than zero Breaking change: Section.mouse_is_on_top now only checks for the section dimensions and not the event capture area. To check if a section should capture an event use Section.should_receive_mouse_event Event capture properties removed and set as attributes that are automatically set Improved some attribute access Improved SectionManager.get_section_by_name SectionManager.clear_sections will now call Section.on_hide_section on each one Improved SectionManager.get_sections with a generator expression Added event_capture param to SectionManager get_first_section and get_sections to allow to get sections based on event capture dimensions or on draw dimensions
…and not on other Vec2
einarf
reviewed
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains improvements to Sections:
Section.draw_ordercan now be smaller than zeroSection.mouse_is_on_topnow only checks for the section dimensions and not the event capture area. To check if a section should capture an event useSection.should_receive_mouse_eventSectionManager.get_section_by_nameSectionManager.clear_sectionswill now callon_hide_sectionon each removed sectionSectionManager.get_sectionswith a generator expressionevent_captureparam to SectionManagerget_first_sectionandget_sectionsmethods to allow to get sections based on event capture dimensions or on draw dimensions