Skip to content

Mypy/fix pep 484#1399

Merged
eruvanos merged 4 commits intodevelopmentfrom
mypy/fix_PEP_484
Nov 8, 2022
Merged

Mypy/fix pep 484#1399
eruvanos merged 4 commits intodevelopmentfrom
mypy/fix_PEP_484

Conversation

@eruvanos
Copy link
Member

@eruvanos eruvanos commented Nov 7, 2022

No description provided.

@eruvanos eruvanos merged commit ef7fa50 into development Nov 8, 2022
@eruvanos eruvanos deleted the mypy/fix_PEP_484 branch November 8, 2022 08:23
@alejcas
Copy link
Member

alejcas commented Nov 10, 2022

Hi, shouldn't methods from spatial_hash.py like check_for_collision_with_list also return List[_SpriteType] instead of List["Sprite"]?

Thanks

@alejcas
Copy link
Member

alejcas commented Nov 10, 2022

for example if I have a subclass of Sprite called Unit whateverUnit.collides_with_list() returns is always expected to be a List[Sprite] and not a List[Unit]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants