Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades pyglet to 2.0.3 and additionally fixes the
camera.pymodule and any necessary example code to reflect the changes to matrix multiplication order inpyglet.math.This currently breaks the example tests with Arcade due to a left-over print statement in Pyglet causing output when loading a freetype font. The tests for examples on Arcade check that the example has no output, so this extra print statement is breaking them. I've submitted a PR to Pyglet to fix this here: pyglet/pyglet#742. This PR will need merged and a release done on Pyglet before we can merge this without breaking the example tests.