Add additional shader tutorials#1455
Add additional shader tutorials#1455pvcraven merged 6 commits intopythonarcade:developmentfrom user2332533:doc/shader_examples
Conversation
|
Small nitpick: I'd rephrase the PR title as "Add additional shader tutorials" since the examples and tutorials folders are separate, and this PR adds content to the tutorials. |
|
hmmmmm "Basic Pygame Program" in the "add shader examples to docs" commit in the index.rst file 😆 |
|
Hopefully now with 100% fewer mistaken names. 🤦♂️ |
|
I left a couple comments which were just simple formatting type things. Are you able to correct? This seems like a worth-while addition to docs. |
|
Hi Paul, Sorry if I'm being dense, but I cannot find your comments for formatting etc. I'm happy to fix any issues but don't know where I should be looking for the comments. |
|
just look at the changes of your commits(click on the commit) and it will appear there |
|
I've gone through all of the commits on this PR and the only comment I can see was Paul's Observation about the wrong library name, I corrected this in the second commit 9b86b14 and marked as resolved. |
I didn't hit the 'finish review' button. |
|
Will need to look at why this test is failing, don't think it has anything to do with the PR. |
Currently failing because of an unrelated issue around a test and pyglet's 2.0.4 release. That'll need to get cleaned up separate from this. |
These examples cover adding inputs (uniforms and buffers) to a shader.
This follows on from the help provided in issue #1453
These examples cover:
Only one additional housekeeping change was made:
Tested locally, build succeeded and docs look fine.