Skip to content

Add additional shader tutorials#1455

Merged
pvcraven merged 6 commits intopythonarcade:developmentfrom
user2332533:doc/shader_examples
Feb 1, 2023
Merged

Add additional shader tutorials#1455
pvcraven merged 6 commits intopythonarcade:developmentfrom
user2332533:doc/shader_examples

Conversation

@user2332533
Copy link
Contributor

These examples cover adding inputs (uniforms and buffers) to a shader.

This follows on from the help provided in issue #1453

These examples cover:

  • A very basic vertex/frament shader
  • Passing a number as a uniform
  • Accessing multiple textures from a shader
  • rendering to a new frambuffer texture

Only one additional housekeeping change was made:

  • Moves gpu_particle_burst into the shaders submenu

Tested locally, build succeeded and docs look fine.

@pushfoo
Copy link
Member

pushfoo commented Jan 11, 2023

Small nitpick: I'd rephrase the PR title as "Add additional shader tutorials" since the examples and tutorials folders are separate, and this PR adds content to the tutorials.

@user2332533 user2332533 changed the title Adds additional shader examples to docs Add additional shader tutorials Jan 11, 2023
@csd4ni3l
Copy link
Contributor

hmmmmm "Basic Pygame Program" in the "add shader examples to docs" commit in the index.rst file 😆

@user2332533
Copy link
Contributor Author

Hopefully now with 100% fewer mistaken names.

🤦‍♂️

@pvcraven
Copy link
Member

I left a couple comments which were just simple formatting type things. Are you able to correct?

This seems like a worth-while addition to docs.

@user2332533
Copy link
Contributor Author

Hi Paul,

Sorry if I'm being dense, but I cannot find your comments for formatting etc. I'm happy to fix any issues but don't know where I should be looking for the comments.

@csd4ni3l
Copy link
Contributor

just look at the changes of your commits(click on the commit) and it will appear there

@user2332533
Copy link
Contributor Author

I've gone through all of the commits on this PR and the only comment I can see was Paul's Observation about the wrong library name, I corrected this in the second commit 9b86b14 and marked as resolved.

@pvcraven
Copy link
Member

I've gone through all of the commits on this PR and the only comment I can see was Paul's Observation about the wrong library name, I corrected this in the second commit 9b86b14 and marked as resolved.

I didn't hit the 'finish review' button.

@pvcraven
Copy link
Member

pvcraven commented Feb 1, 2023

Will need to look at why this test is failing, don't think it has anything to do with the PR.

@pvcraven
Copy link
Member

pvcraven commented Feb 1, 2023

Will need to look at why this test is failing, don't think it has anything to do with the PR

Currently failing because of an unrelated issue around a test and pyglet's 2.0.4 release. That'll need to get cleaned up separate from this.

@pvcraven pvcraven merged commit 10ae3a1 into pythonarcade:development Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants