Skip to content

1502 create lines fix#1522

Merged
pvcraven merged 4 commits intopythonarcade:developmentfrom
kosvitko:1502_create_lines_fix
Feb 16, 2023
Merged

1502 create lines fix#1522
pvcraven merged 4 commits intopythonarcade:developmentfrom
kosvitko:1502_create_lines_fix

Conversation

@kosvitko
Copy link
Contributor

@kosvitko kosvitko commented Feb 15, 2023

  1. added fix to create_lines_with_colors
  2. created triangles_strip wrapper to handle other functions which use that option
  3. added some comments to documentation section of changed functions

sidenote regarding related code:
create_line_strip function in original version of code causes twice more triangles to be rendered due to call to triangle_strip function (one triangle per vertex, so 4 triangles per line segment).
This behavior could be changed (2 triangles would be rendered for one line segment) by using no strip triangles function, but vertex array would increase 1.5 times (6 vertex for one line segment vs 4)

Built and tested locally

Closes #1502

@pvcraven
Copy link
Member

Hi, looks like the auto-code check found some minor formatting issues:
https://github.com/pythonarcade/arcade/actions/runs/4183291764/jobs/7258906425
Can you fix and make the formatters happy?

@kosvitko
Copy link
Contributor Author

definitely. just for the first time the workflow was disabled, so I wan't able to run checks ;)

@kosvitko
Copy link
Contributor Author

ok. one more fix to complete.

@pvcraven pvcraven merged commit 3e6eb61 into pythonarcade:development Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create_lines_with_colors doesn't work properly for width > 1

2 participants