Improve contributing.md docs#1529
Merged
einarf merged 1 commit intopythonarcade:developmentfrom Feb 17, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #995. However, this PR does not concern itself with all of the things that may be discussed in #995. It can and should be merged if it makes a net improvement in documentation. We discussed this on Discord:
https://discord.com/channels/458662222697070613/705076586986078350/1076173114410549258
This PR focuses on one thing:
What commands should a first-time contributor run to:
a) install development dependencies
b) run automated tests
c) submit a pull request that improves arcade's code in some way
It is not concerned with installing arcade from source. That is a separate topic covered by different documentation.
Other ideas:
However, if we get mired in discussion, then we should focus on merging this PR as-is and making further improvements in other PRs.