Adding a random.glsl for use with glsl code injection#1569
Merged
einarf merged 5 commits intopythonarcade:developmentfrom Feb 22, 2023
DragonMoffon:new-random-glsl
Merged
Adding a random.glsl for use with glsl code injection#1569einarf merged 5 commits intopythonarcade:developmentfrom DragonMoffon:new-random-glsl
einarf merged 5 commits intopythonarcade:developmentfrom
DragonMoffon:new-random-glsl
Conversation
…ff with random white noise inside shaders can. (NOTE: it is pseudo-random noise). This noise is focused on generating visually good-looking noise and there are no assurances on the mathematical quality.
pushfoo
requested changes
Feb 22, 2023
Member
pushfoo
left a comment
There was a problem hiding this comment.
Aside from needing to move the docstring to the top of the file, this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a random.glsl for use with glsl code injection, which can be included using the common argument of
ArcadeContext,load_programandContext.program.Created so all who want to do stuff with random white noise inside shaders can. This noise is focused on generating visually good-looking noise, and there are no assurances on the mathematical quality.
(NOTE: it is pseudo-random noise).