Skip to content

Remove typing.cast() in hot code path #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
einarf merged 1 commit into from
Feb 22, 2023
Merged

Remove typing.cast() in hot code path #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arcade/geometry_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""
Functions for calculating geometry.
"""
from typing import cast
from arcade.types import PointList


Expand Down Expand Up @@ -48,7 +47,8 @@ def are_polygons_intersecting(poly_a: PointList,
if max_b is None or projected > max_b:
max_b = projected

if cast(float, max_a) <= cast(float, min_b) or cast(float, max_b) <= cast(float, min_a):
# Avoid typing.cast() because this is a very hot path
if max_a <= min_b or max_b <= min_a: # type: ignore
return False

return True
Expand Down