Skip to content

Conversation

@pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 19, 2023

tl;dr

  1. Closes CI doesn't pick up multiple whitespace style issues #1701
  2. Switching to ruff broke linting in since it's not actually a drop-in replacement
  3. Adding "W" to the select list in [tool.ruff] re-enables whitepsace linting

We should merge this PR quickly because:

  1. It can affect PyCon mentored sprint participants
  2. It has already been affecting junior contributors (see Clean _check_for_collision #1702 (comment)).
  3. Whitespace issues have been accumulating since February when we switched to ruff (1a3e993)

@pushfoo pushfoo changed the title Fix whitespace linter config + backlog of whitespace issues Fix whitespace linting + backlog of whitespace issues Apr 19, 2023
@Cleptomania Cleptomania merged commit 96f3638 into pythonarcade:development Apr 19, 2023
@pushfoo pushfoo deleted the re_enable_linting branch May 7, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI doesn't pick up multiple whitespace style issues

2 participants