[Fix #56] Fixed statistics mobile view for some resolution#61
[Fix #56] Fixed statistics mobile view for some resolution#61CuriousLearner merged 5 commits intopythonindia:masterfrom
Conversation
CuriousLearner
left a comment
CuriousLearner
left a comment
There was a problem hiding this comment.
Can you please use default bootstrap classes?
Also, please avoid inline styling.
|
@CuriousLearner In my merged PR #30 . I Implemented changes for mobile view using only bootstrap for all resolutions possible. But #56 issue was raised. Actually problem was only between resolution 480px to 569px, so I decided to change it using media queries which will not affect other classes on website. |
|
Breakpoints eventually cause trouble when the code base size increases. Can you please use bootstrap grid instead? |
|
@CuriousLearner I have fixed it now with bootstrap grid only. The problem was caused by a supportive CSS file that had such rules for that resolution. The issue looks fixed now. |
|
|
||
| .hr-statistics{ | ||
| color: white; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Leave a line at the end of the file.
There was a problem hiding this comment.
@CuriousLearner done. But I don't know why it's not showing here.
There was a problem hiding this comment.
@pradeepgangwar your new commit has been added to this PR when you pushed. The review you are seeing is showing the code at the moment of review and it'll remain same.
There was a problem hiding this comment.
@realslimshanky fine. @CuriousLearner please review the PR with new changes.
|
Can be closed now |
|
@CuriousLearner Please see this. I think it can be merged now. |
|
LGTM 🍫 |
5 participants
Issue No. - #56
Link to view Changes - Gh-Pages
Changes Made: