You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes a null-crash in the footer when the backend returns null for a missing menu (the API returns null when no menu with that identifier is configured for a conference).
No frontend tests for the null-menu case. The bug this PR fixes had no test, and the fix also has no test. If footerEn or footerIt is null (a real scenario confirmed by the backend test at backend/api/tests/schema/conference/test_menu.py), there's nothing preventing a regression. A snapshot or render test that passes null menus would catch this.
Same class of bug exists in the header.frontend/src/components/header/index.tsx destructures data || { conference: {} } — if data is defined but data.conference is null, that destructure throws. The individual ?? [] guards on links access don't protect against this. Worth fixing in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ToDo