Skip to content

Conversation

@MU-Software
Copy link
Member

주요 변경 사항

  • @pyconkr-common, @pyconkr-shop, @src 패키지를 추가합니다.
    • 구조
      • @pyconkr-common : 공통적으로 사용될 util이 담기는 패키지
      • @pyconkr-shop : Shop API와 결제, Hook 등이 담기는 패키지
      • @src : src 디렉토리의 alias
    • 이런 구조를 한 이유
      • 추후 Admin에서도 이 패키지들을 사용해야 할 수 있습니다.
      • 별도 @pyconkr 패키지용 repo를 만들기 전에는 우선 별도 디렉토리에 구성해서, 나중에 마이그레이션이 쉽도록 했습니다 🙏
  • 그 외 몇가지 사용하게 될 패키지들을 추가합니다.

@MU-Software MU-Software changed the title feat: 공통 util 관련 디렉토리 및 Cookie 관련 도구 추가 feat: pyconkr-shop API 호출을 위한 hook 추가 Apr 20, 2025

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 20, 2025 10:07

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 20, 2025 10:08

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 20, 2025 10:11

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 20, 2025 10:14

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 21, 2025 22:47

This comment was marked as resolved.

@MU-Software MU-Software requested a review from Copilot April 21, 2025 22:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new package structure to support the pyconkr-shop API calls and payment hooks while also adding shared utilities. Key changes include:

  • Updates to Vite configuration for environment variables and path aliases.
  • Addition of the Shop API utilities, schemas, hooks, and API client in the new @pyconkr-shop package.
  • Inclusion of a common cookie utility in the @pyconkr-common package.

Reviewed Changes

Copilot reviewed 8 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vite.config.ts Added environment directory and alias configuration.
package/pyconkr-shop/utils/portone.ts Implemented API call helper for initiating PortOne purchase.
package/pyconkr-shop/schemas/index.ts Defined and exported shop API schemas.
package/pyconkr-shop/hooks/index.ts Provided hooks for API interactions using react-query.
package/pyconkr-shop/apis/index.ts Implemented API routes for shop-related actions.
package/pyconkr-shop/apis/client.ts Created an API client with error handling using axios.
package/pyconkr-common/utils/cookie.ts Added a simple cookie retrieval utility.
Files not reviewed (5)
  • dotenv/.env.development: Language not supported
  • dotenv/.env.production: Language not supported
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported
  • tsconfig.app.json: Language not supported

@pythonkr pythonkr deleted a comment from Copilot AI Apr 21, 2025
@MU-Software MU-Software requested a review from Copilot April 23, 2025 14:24

This comment was marked as resolved.

@MU-Software MU-Software merged commit 06032c2 into main May 1, 2025
@MU-Software MU-Software deleted the feature/add-shop-api-hook branch May 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants