-
Notifications
You must be signed in to change notification settings - Fork 2
feat: pyconkr-shop Component 및 테스트 페이지 추가 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new shop components and testing pages while refactoring several APIs and schemas for the pyconkr-shop project. Key changes include:
- New order and cart components with refund, option patch, and receipt functionalities.
- A dedicated MDX test page and updated routing in App.tsx to toggle between shop and MDX test views.
- Updates to API endpoints, schema definitions, manifest configuration, and minor dependency/workspace tweaks.
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/debug/page/shop_component/order.tsx | Implements a new order component with refund and option patch capabilities. |
| src/debug/page/shop_component/cart.tsx | Implements a new cart component to manage product removal and order initiation. |
| src/debug/page/mdi_test.tsx | Introduces an MDX test page with updated import and export patterns. |
| src/App.tsx | Adds tab-based navigation between shop and MDX test pages. |
| src/App.css | Removed obsolete styles. |
| public/site.webmanifest | Updated manifest configuration for the new site look. |
| pnpm-workspace.yaml | Added esbuild to the list of built dependencies. |
| package/pyconkr-shop/utils/index.ts | Minor utility function updates supporting shop API functionality. |
| package/pyconkr-shop/schemas/index.ts | Adjusted schema types to support nullable leftover_stock and refine option group types. |
| package/pyconkr-shop/hooks/index.ts | Added new hook for patching order options along with a naming change in the mutation key. |
| package/pyconkr-shop/components/* | Added/updated shop components, including signin guard and option group inputs. |
| package/pyconkr-shop/apis/index.ts | Updated API endpoints to match new design requirements. |
| package.json | Upgraded dependencies and added the mkcert plugin. |
| index.html | Updated meta tags, favicon links, and manifest reference. |
| dotenv/* | Added necessary environment variables for IMP account integration. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
package/pyconkr-shop/hooks/index.ts:146
- The mutationKey 'CART_ITEM_APPEND' used in useOptionsOfOneItemInOrderPatchMutation does not clearly convey its purpose of patching order options. Consider renaming it to a more descriptive key (e.g., 'ORDER_OPTIONS_PATCH').
mutationKey: MUTATION_KEYS.CART_ITEM_APPEND,
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
추가 사항