Fix H100 filter #29
Merged
Fix H100 filter #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a filtering issue in the H100 queue monitoring script by switching from a prefix match to an exact match filter. The change prevents incorrect matches with machine types like "linux.idc.xpu" when filtering for a specific H100 machine type.
- Changed from
startsWith()to exact equality (===) for machine type filtering - Updated error message to reflect the exact match behavior
- Removed an unnecessary empty line for cleaner code formatting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
OpenTofu plan for prod No changes. Your infrastructure matches the configuration.❌ Plan not applied in Tofu Apply #29 (Plan has changed) |
The filter was matching linux.idc.xpu when it shouldn't have. This change switches to an exact match filter to resolve that issue. Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
zxiiro
force-pushed
the
zxiiro/queue-alerts-meta-h100
branch
from
59617ec to
b84fd1a
Compare
jordanconway
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter was matching linux.idc.xpu when it shouldn't have. This change switches to an exact match filter to resolve that issue.