Skip to content

rename MXTensor's _scale_e8m0 to scale #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

rename MXTensor's _scale_e8m0 to scale #3164

merged 1 commit into from
Oct 13, 2025

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 13, 2025 •
edited
Loading

Summary:

Align naming with other tensor subclasses.

(AI assisted)

Test Plan:

pytest test/prototype/mx_formats/ -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

@vkuzo
Update
21cc7e5 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 13, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

vkuzo added a commit that referenced this pull request Oct 13, 2025
@vkuzo
rename MXTensor's _scale_e8m0 to scale
e005c77 
Summary:

Align naming with other tensor subclasses.

Test Plan:

```
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: ca6e52e
ghstack-comment-id: 3398259511
Pull-Request: #3164
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3164

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 21cc7e5 with merge base 6c24a7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 13, 2025
This was referenced Oct 13, 2025
Merged
Merged
Merged
@vkuzo vkuzo merged commit 8a4f586 into main Oct 13, 2025
50 of 52 checks passed
@vkuzo vkuzo mentioned this pull request Oct 14, 2025
Merged
vkuzo added a commit that referenced this pull request Oct 14, 2025
@vkuzo
fixup missing callsites for _scale_e8m0 -> scale rename
60778aa 
Summary:

Missed a couple of callsites in #3164,
fixing

Missed these

Test Plan:

// all remaining use cases look expected
```bash
cd torchao
grep -r scale_e8m0 .
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: a190850
ghstack-comment-id: 3402957928
Pull-Request: #3173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @jerryzh168