Skip to content

rename NVFP4Tensor's _scale_e4m3 field to scale #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2025
Merged

rename NVFP4Tensor's _scale_e4m3 field to scale #3166

merged 4 commits into from
Oct 13, 2025

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 13, 2025

Summary:

To align naming with other tensors

(AI assisted)

Test Plan:

pytest test/prototype/mx_formats/ -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 2 commits October 13, 2025 09:45
@vkuzo
Update
21cc7e5 
[ghstack-poisoned]
@vkuzo
Update
8d13840 
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 13, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

vkuzo added a commit that referenced this pull request Oct 13, 2025
@vkuzo
rename NVFP4Tensor's _scale_e4m3 field to scale
af4df39 
Summary:

To align naming with other tensors

(AI assisted)

Test Plan:

```
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 577be95
ghstack-comment-id: 3398383162
Pull-Request: #3166
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3166

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vkuzo vkuzo mentioned this pull request Oct 13, 2025
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 13, 2025
@vkuzo
Update
31defd5 
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Oct 13, 2025
@vkuzo
rename NVFP4Tensor's _scale_e4m3 field to scale
1e64abf 
Summary:

To align naming with other tensors

(AI assisted)

Test Plan:

```
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: f63bfe0
ghstack-comment-id: 3398383162
Pull-Request: #3166
@vkuzo vkuzo mentioned this pull request Oct 13, 2025
Merged
@vkuzo vkuzo requested a review from jerryzh168 October 13, 2025 17:39
@vkuzo vkuzo mentioned this pull request Oct 13, 2025
Merged
@vkuzo
Update
eaf92b9 
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/141/head to main October 13, 2025 21:07
@vkuzo vkuzo merged commit 1c7ceea into main Oct 13, 2025
35 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkuzo @jerryzh168