Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3318
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit b7156ec with merge base 415e0e8 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
left a comment
There was a problem hiding this comment.
Sounds good to me.
But I'll let an ao maintainer accept the PR
jerryzh168
left a comment
There was a problem hiding this comment.
looks good, as long as it works
torchao/_models/llama/generate.py
Outdated
| if torch.xpu.is_available() | ||
| else "cpu" | ||
| ) | ||
| default_device = acc.type if (acc := torch.accelerator.current_accelerator(True)) else "cpu" |
There was a problem hiding this comment.
maybe spell out the arg of current_accelerator to be clearer https://docs.pytorch.org/docs/stable/generated/torch.accelerator.current_accelerator.html
57478ea to
09e0994
Compare
|
@pytorchbot label "topic: improvement" |
09e0994 to
85bf902
Compare
|
The CI workflow needs to be triggered. |
85bf902 to
6dd4c33
Compare
|
@jerryzh168 I rebase this PR to the latest main already. Could you help re-trigger the CI. |
6dd4c33 to
810e31a
Compare
|
@pytorchbot merge |
Merge failedReason: 1 mandatory check(s) are pending/not yet run. The first few are:
Dig deeper by viewing the pending checks on hud |
|
@guangyey we can't use pytorchbot here to merge the PR. we just click the button to merge |
810e31a to
1e180ae
Compare
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
Thanks, @jerryzh168. I’ll reach out to the Intel team to re-trigger the CI and land the PR once all checks are green. |
06471e4 to
b7156ec
Compare
|
The failure is irrelevant to this PR. The same failure can be found in https://github.com/pytorch/ao/actions/runs/20529844203/job/58979473220 that already landed in #3548 File "/opt/conda/envs/venv/lib/python3.10/site-packages/torchao/dtypes/nf4tensor.py", line 940, in __torch_dispatch__
raise NotImplementedError(
NotImplementedError: NF4Tensor dispatch: attempting to run _c10d_functional._wrap_tensor_autograd.default, this is not supported
To execute this test, run the following from the base repo dir:
python test/dtypes/test_nf4.py TestComm.test_comm |
|
Double confirmed, the UT fail is not related to this PR. Merged. |
|
Thanks for your help! |
Motivation
Unify llama generate utils via
torch.acceleratorAPIs.cc @albanD