Merged
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom):
|
vkuzo
added a commit
that referenced
this pull request
Dec 26, 2025
Summary: pytorch/pytorch#168140 added a new op, fixing various training callsites to properly handle it Test Plan: ``` ./test/float8/test_dtensor.sh with-proxy python test/test_low_bit_optim.py TestFSDP2.test_fsdp2 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8b1fbb1 ghstack-comment-id: 3692922247 Pull-Request: #3548
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3548
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f3cee71 with merge base a2b4750 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Dec 26, 2025
Summary: pytorch/pytorch#168140 added a new op, fixing various training callsites to properly handle it Test Plan: ``` ./test/float8/test_dtensor.sh with-proxy python test/test_low_bit_optim.py TestFSDP2.test_fsdp2 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2e48744 ghstack-comment-id: 3692922247 Pull-Request: #3548
jerryzh168
approved these changes
Dec 26, 2025
vkuzo
added a commit
that referenced
this pull request
Dec 26, 2025
Summary: pytorch/pytorch#168140 added a new op, fixing various training callsites to properly handle it Test Plan: ``` ./test/float8/test_dtensor.sh with-proxy python test/test_low_bit_optim.py TestFSDP2.test_fsdp2 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f0fe934 ghstack-comment-id: 3692922247 Pull-Request: #3548
vkuzo
added a commit
that referenced
this pull request
Dec 26, 2025
Summary: pytorch/pytorch#168140 added a new op, fixing various training callsites to properly handle it Test Plan: ``` ./test/float8/test_dtensor.sh with-proxy python test/test_low_bit_optim.py TestFSDP2.test_fsdp2 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 93c11ac ghstack-comment-id: 3692922247 Pull-Request: #3548
vkuzo
commented
Dec 26, 2025
| _test_mxfp8_mlp_tensor_parallelism_dim1_triton, | ||
| ] | ||
| if is_sm_at_least_100(): | ||
| tests.append(_test_mxfp8_mlp_tensor_parallelism_dim1_triton) |
Contributor
Author
There was a problem hiding this comment.
not related to this PR, but also needed to fix 4xh100 CI
Contributor
Author
|
need to also fix nf4 tests |
Contributor
Author
|
we can do that in a future PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
pytorch/pytorch#168140 added a new op,
fixing various training callsites to properly handle it
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: