Build ffmpeg-features on macOS wheel binary dist #2122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
changed the title
mthrok
force-pushed
the
build-wheel
branch
6 times, most recently
from
394c6b8 to
1e0b14c
Compare
carolineechen
approved these changes
Jan 4, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
Summary: Currently, macOS CI jobs install `pkg-config` and `wget` with `brew`. This is problematic as brew takes a long time with auto-update, and disabling the auto-update is not an ideal solution. Conda also distributes these packages, so switching to conda. Example issues with brew installation. https://app.circleci.com/pipelines/github/pytorch/audio/7825/workflows/53965bcf-6ddf-4e42-ad52-83fd1bbab717 This commit removes the use of `brew` by 1. Replacing the use of `wget` with `curl` (pre-installed in most distro) 2. Install `pkg-condig` from conda. Note: All the macOS jobs, including binary build jobs, uses conda. Using `pkg-config` from Conda makes it easy to discover the packages installed from conda. (like `ffmpeg` in #2122) 3. Add `pkg-config` to conda build-time dependency 4. Make sure that the availability of `pkg-config` is explicitly checked when `sox` is being configured. (otherwise, it will fail at somewhere in the middle of build process with somewhat unintuitve error message) Pull Request resolved: #1873 Reviewed By: carolineechen, nateanl Differential Revision: D33404975 Pulled By: mthrok fbshipit-source-id: ae512d3a3a422ebfe3b46c492bed44deecc36e72
Contributor
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This commit enable ffmpeg-feature build on wheel-based binary distribution on macOS. For macOS, since the underlying Python env is Conda, it installs `ffmpeg` from conda.
Contributor
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jan 5, 2022
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: Currently, macOS CI jobs install `pkg-config` and `wget` with `brew`. This is problematic as brew takes a long time with auto-update, and disabling the auto-update is not an ideal solution. Conda also distributes these packages, so switching to conda. Example issues with brew installation. https://app.circleci.com/pipelines/github/pytorch/audio/7825/workflows/53965bcf-6ddf-4e42-ad52-83fd1bbab717 This commit removes the use of `brew` by 1. Replacing the use of `wget` with `curl` (pre-installed in most distro) 2. Install `pkg-condig` from conda. Note: All the macOS jobs, including binary build jobs, uses conda. Using `pkg-config` from Conda makes it easy to discover the packages installed from conda. (like `ffmpeg` in pytorch#2122) 3. Add `pkg-config` to conda build-time dependency 4. Make sure that the availability of `pkg-config` is explicitly checked when `sox` is being configured. (otherwise, it will fail at somewhere in the middle of build process with somewhat unintuitve error message) Pull Request resolved: pytorch#1873 Reviewed By: carolineechen, nateanl Differential Revision: D33404975 Pulled By: mthrok fbshipit-source-id: ae512d3a3a422ebfe3b46c492bed44deecc36e72
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This commit enable ffmpeg-feature build on wheel-based binary distribution on macOS. For macOS, since the underlying Python env is Conda, it installs `ffmpeg` from conda. Depends on pytorch#1873 Pull Request resolved: pytorch#2122 Reviewed By: carolineechen, nateanl Differential Revision: D33409113 Pulled By: mthrok fbshipit-source-id: a73839087548010353422109b33e89e262c12a57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enable ffmpeg-feature build on wheel-based binary distribution on macOS.
For macOS, since the underlying Python env is Conda, it installs
ffmpegfrom conda.Depends on #1873