Improve the compute score script to accept json directory or json file without requiring a config. - #144
Merged
Merged
Conversation
… json file without requiring a config. [ghstack-poisoned]
…irectory or json file without requiring a config." [ghstack-poisoned]
wconstab
reviewed
Oct 26, 2020
| with open(args.configuration) as cfg_file: | ||
| config = yaml.full_load(cfg_file) | ||
|
|
||
| if args.configuration is not None: |
Contributor
There was a problem hiding this comment.
does it make sense to reduce lines of code by putting the config-file generation into the existing code blocks
if args.benchmark_data_file is not None:
elif args.benchmark_data_dir is not None:
?
You can still have a check at line 53
else:
if args.benchmark_data_file is None and args.benchmark_data_file is None, raise Exception "invalid arg.."
Contributor
Author
There was a problem hiding this comment.
That makes sense. I have updated the code.
wconstab
approved these changes
Oct 26, 2020
wconstab
left a comment
wconstab
left a comment
Contributor
There was a problem hiding this comment.
LGTM! minor nit comment inline
…irectory or json file without requiring a config." [ghstack-poisoned]
…irectory or json file without requiring a config." [ghstack-poisoned]
…irectory or json file without requiring a config." [ghstack-poisoned]
…irectory or json file without requiring a config." [ghstack-poisoned]
xuzhao9
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: