Added a step to upload to Amazon S3.#326
Merged
Merged
Conversation
wconstab
reviewed
Mar 22, 2021
| path: benchmark-result-*.json | ||
| - name: Upload results to Amazon S3 | ||
| run: | | ||
| LAST_MODIFIED_DIR=$(find ${HOME}/benchmark-results-v0.1/ -mindepth 1 -maxdepth 1 -type d -exec stat -t {} \; | sort -r -n -k 13,13 | head -1 | cut -d " " -f 1) |
Contributor
There was a problem hiding this comment.
is this LAST_MODIFED_DIR command very safe? would the uploader do something bad if LAST_MODIFIED_DIR is a duplicate of one uploaded before? or if it is empty?
Contributor
Author
There was a problem hiding this comment.
If LAST_MODIFIED_DIR is a duplicate, the uploader will upload the file again. Since --torchbench-result-dir is a required argument, if it is empty the upload_s3.py will fail with error.
wconstab
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.