Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Bump numpy versions to 1.17 #397

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Bump numpy versions to 1.17 #397

merged 2 commits into from
Jan 27, 2020

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jan 27, 2020 •
edited
Loading

Was causing macOS builds for python 3.8 to fail, see CirclCI Build

Jan 27 22:35:50 
Jan 27 22:35:50 UnsatisfiableError: The following specifications were found
Jan 27 22:35:50 to be incompatible with the existing python installation in your environment:
Jan 27 22:35:50 
Jan 27 22:35:50 Specifications:
Jan 27 22:35:50 
Jan 27 22:35:50   - numpy=1.15 -> python[version='>=2.7,<2.8.0a0|>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

Should resolve issues found in pytorch/pytorch#31948

@seemethere
wheel: bump numpy version -> 1.17
89aded2 
Numpy version 1.17 is the first version to officially support Python 3.8

https://github.com/numpy/numpy/releases/tag/v1.17.5

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
conda: bump numpy -> 1.17
d912ecb 
1.17 is the first numpy release to support python 3.8

https://github.com/numpy/numpy/releases/tag/v1.17.5

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere requested a review from soumith January 27, 2020 23:29
@seemethere seemethere merged commit 8a1bb73 into pytorch:master Jan 27, 2020
@seemethere seemethere deleted the bump_117 branch January 27, 2020 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seemethere