Skip to content

NXP backend: Add support for aten.clamp.default.#17327

Merged
MartinPavella merged 1 commit into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend
Feb 18, 2026
Merged

NXP backend: Add support for aten.clamp.default.#17327
MartinPavella merged 1 commit into
pytorch:mainfrom
nxp-upstream:nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend

Conversation

@MartinPavella
Copy link
Copy Markdown
Collaborator

@MartinPavella MartinPavella commented Feb 10, 2026

Summary

This PR adds support for the aten.clamp.default operator no NXP backend.

Test plan

Unit-tests provided.

cc @robert-kalmar @JakeStevens @digantdesai

@MartinPavella MartinPavella added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Feb 10, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17327

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit caacdc0 with merge base c7c7c0a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2026
@MartinPavella
Copy link
Copy Markdown
Collaborator Author

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend branch from add044e to c90bab3 Compare February 10, 2026 09:25
@MartinPavella
Copy link
Copy Markdown
Collaborator Author

@novak-vaclav can you please take a look at this PR?

@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend branch 2 times, most recently from d3b40eb to f18ac4e Compare February 17, 2026 14:19
Comment thread backends/nxp/tests/ir/converter/node_converter/test_clamp_converter.py Outdated
Comment thread docs/source/backends/nxp/op-support.csv
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend branch from f18ac4e to 5b1c97c Compare February 18, 2026 08:09
@MartinPavella MartinPavella force-pushed the nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend branch from 5b1c97c to caacdc0 Compare February 18, 2026 08:09
@MartinPavella
Copy link
Copy Markdown
Collaborator Author

The failing checks are unrelated and the internal build is passing. Merging.

@MartinPavella MartinPavella merged commit cfa1768 into pytorch:main Feb 18, 2026
150 of 153 checks passed
@MartinPavella MartinPavella deleted the nxg01483/EIEX-710-add-support-for-aten.clamp-to-nxp-backend branch February 18, 2026 10:32
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Feb 18, 2026

Hi this might have got the size tests to fail I see you got
pull / test-binary-size-linux-gcc / linux-job (gh)

And see this in the hud: https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=test-binary-size&useRegexFilter=true

Note sure why as this PR seem to only touch NXP backend stuff, so it might be unrelated.

@MartinPavella
Copy link
Copy Markdown
Collaborator Author

Hi this might have got the size tests to fail I see you got pull / test-binary-size-linux-gcc / linux-job (gh)

And see this in the hud: https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=test-binary-size&useRegexFilter=true

Note sure why as this PR seem to only touch NXP backend stuff, so it might be unrelated.

I have no idea what that test relates to, so I don't know how to investigate the failure. Can I rely on you to find out what's wrong? Or is there something I can do?

SS-JIA added a commit that referenced this pull request Feb 18, 2026
Summary:
TSIA. Revert due to breaking Meta internal tests.

See #17327 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants