Skip to content

Revert "NXP backend: Add support for aten.clamp.default. (#17327)"#17530

Closed
SS-JIA wants to merge 1 commit into
mainfrom
ssj_revert_nxp_clamp
Closed

Revert "NXP backend: Add support for aten.clamp.default. (#17327)"#17530
SS-JIA wants to merge 1 commit into
mainfrom
ssj_revert_nxp_clamp

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Feb 18, 2026

Summary:
TSIA. Revert due to breaking Meta internal tests.

See #17327 for more details.

Summary:
TSIA. Revert due to breaking Meta internal tests.

See #17327 for more details.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17530

Note: Links to docs will display an error until the docs builds have been completed.

❌ 33 New Failures, 13 Pending, 16 Unrelated Failures

As of commit 7ecbad9 with merge base cfbc158 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA
Copy link
Copy Markdown
Contributor Author

SS-JIA commented Feb 18, 2026

cc: @MartinPavella

@SS-JIA SS-JIA closed this Feb 18, 2026
@robert-kalmar
Copy link
Copy Markdown
Collaborator

robert-kalmar commented Feb 18, 2026

Hi @SS-JIA ,
can you be more specific how this commit broke Meta internal CI. As we don't see the build results we cannot address them properly.

And as you closed the ticket without merge, was it a false positive or the problem is still present?

@MartinPavella
Copy link
Copy Markdown
Collaborator

MartinPavella commented Feb 19, 2026

Hi @SS-JIA ,
I have fixed the probable cause of this issue in my PR.

Edit: Now I see Jake already had the fix in #17548.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants