Add dedicated HiFi kernel for max pool 2d (#18240)#18240
Open
mcremon-meta wants to merge 3 commits intomainfrom
Open
Add dedicated HiFi kernel for max pool 2d (#18240)#18240mcremon-meta wants to merge 3 commits intomainfrom
mcremon-meta wants to merge 3 commits intomainfrom
Conversation
Contributor
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96874522. |
hsharma35
approved these changes
Mar 17, 2026
This PR needs a
|
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Summary: As titled. Calls into nnlib directly. Differential Revision: D96874522
ece3267 to
4d2cd10
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: #18240 As titled. Calls into nnlib directly. Differential Revision: D96874522
4d2cd10 to
20a30d5
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Summary: As titled. Calls into nnlib directly. Reviewed By: hsharma35 Differential Revision: D96874522
20a30d5 to
3b7b0eb
Compare
3b7b0eb to
4673186
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: #18240 As titled. Calls into nnlib directly. Reviewed By: hsharma35 Differential Revision: D96874522
Summary: As titled. Useful especially for resnet backbones, to reduce quant/dequant pressure. Reviewed By: DrJessop Differential Revision: D96683989
Summary: As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last. Reviewed By: hsharma35 Differential Revision: D96869747
Summary: As titled. Calls into nnlib directly. Reviewed By: hsharma35 Differential Revision: D96874522
4673186 to
9dca6e0
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Summary: As titled. Calls into nnlib directly. Reviewed By: hsharma35 Differential Revision: D96874522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. Calls into nnlib directly.
Reviewed By: hsharma35
Differential Revision: D96874522