Skip to content

Add dedicated HiFi kernel for max pool 2d (#18240)#18240

Open
mcremon-meta wants to merge 3 commits intomainfrom
export-D96874522
Open

Add dedicated HiFi kernel for max pool 2d (#18240)#18240
mcremon-meta wants to merge 3 commits intomainfrom
export-D96874522

Conversation

@mcremon-meta
Copy link
Contributor

@mcremon-meta mcremon-meta commented Mar 17, 2026

Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18240

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 10 Cancelled Jobs, 2 Pending, 1 Unrelated Failure

As of commit 9dca6e0 with merge base b7ca1a4 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 17, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96874522.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title Add dedicated HiFi kernel for max pool 2d Add dedicated HiFi kernel for max pool 2d (#18240) Mar 17, 2026
meta-codesync bot pushed a commit that referenced this pull request Mar 17, 2026
Summary:

As titled. Calls into nnlib directly.

Differential Revision: D96874522
mcremon-meta added a commit that referenced this pull request Mar 17, 2026
Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Differential Revision: D96874522
meta-codesync bot pushed a commit that referenced this pull request Mar 17, 2026
Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522
mcremon-meta added a commit that referenced this pull request Mar 17, 2026
Summary:
Pull Request resolved: #18240

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522
Summary:

As titled. Useful especially for resnet backbones, to reduce quant/dequant pressure.

Reviewed By: DrJessop

Differential Revision: D96683989
Summary:

As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last.

Reviewed By: hsharma35

Differential Revision: D96869747
Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522
meta-codesync bot pushed a commit that referenced this pull request Mar 17, 2026
Summary:

As titled. Calls into nnlib directly.

Reviewed By: hsharma35

Differential Revision: D96874522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants