Conversation
Summary: Fix build Differential Revision: D97649745
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18399
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 1 New Failure, 2 Unrelated FailuresAs of commit 444975d with merge base f7977a6 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97649745. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR fixes Buck build packaging for the CUDA Triton kernels by ensuring the newly added topk Triton kernel is included in the triton_kernels Python library target.
Changes:
- Add
backends/cuda/triton/kernels/topk.pyto thetriton_kernelssrcslist inbackends/cuda/TARGETS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| srcs = [ | ||
| "triton/kernels/__init__.py", | ||
| "triton/kernels/sdpa.py", | ||
| "triton/kernels/topk.py", |
There was a problem hiding this comment.
triton/kernels/__init__.py unconditionally imports executorch.backends.cuda.triton.kernels.fused_moe, but triton/kernels/fused_moe.py is not listed in this triton_kernels target's srcs. This can break Buck packaging/imports (any import of ...triton.kernels.* executes __init__.py). Add triton/kernels/fused_moe.py to srcs (and consider adding other imported kernel modules as needed), or make the import conditional in __init__.py if it’s intentionally excluded from the target.
| "triton/kernels/topk.py", | |
| "triton/kernels/topk.py", | |
| "triton/kernels/fused_moe.py", |
Summary: Fix build
Differential Revision: D97649745