Skip to content

Add topk.py to BUCK #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Mar 23, 2026
Merged

Add topk.py to BUCK #18399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/cuda/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ runtime.python_library(
srcs = [
"triton/kernels/__init__.py",
"triton/kernels/sdpa.py",
"triton/kernels/topk.py",
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triton/kernels/__init__.py unconditionally imports executorch.backends.cuda.triton.kernels.fused_moe, but triton/kernels/fused_moe.py is not listed in this triton_kernels target's srcs. This can break Buck packaging/imports (any import of ...triton.kernels.* executes __init__.py). Add triton/kernels/fused_moe.py to srcs (and consider adding other imported kernel modules as needed), or make the import conditional in __init__.py if it’s intentionally excluded from the target.

Suggested change
"triton/kernels/topk.py",
"triton/kernels/topk.py",
"triton/kernels/fused_moe.py",

Copilot uses AI. Check for mistakes.
],
visibility = [
"//executorch/backends/cuda/...",
Expand Down
Loading