[ExecuTorch][WebGPU] Upload named-data constants in WebGPUGraph#19962
Merged
meta-codesync[bot] merged 1 commit intoJun 3, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19962
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit 05cf3c0 with merge base 915a82d ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Jun 2, 2026
This PR needs a
|
SS-JIA
approved these changes
Jun 3, 2026
JulianCloudNTH
added a commit
to JulianCloudNTH/executorch
that referenced
this pull request
Jun 3, 2026
Summary: The Vulkan serializer that the WebGPU backend reuses stores every non-empty constant in the PTE's named-data map with `offset == UINT64_MAX` and a `named_key`, rather than inline in the VK00 blob. `WebGPUGraph::build` previously handled only inline constants, so a delegated op's constant weights were never uploaded and the op produced all zeros. `build` now also fetches named-data constants via `NamedDataMap::get_data`, mirroring the path `VulkanBackend` already uses. `aten.add` was unaffected since it has no constant tensors; the first consumer is the `rms_norm` op in the child diff. ghstack-source-id: 389182397 exported-using-ghexport Reviewed By: SS-JIA Differential Revision: D107288998
JulianCloudNTH
added a commit
to JulianCloudNTH/executorch
that referenced
this pull request
Jun 3, 2026
Summary: Pull Request resolved: pytorch#19962 The Vulkan serializer that the WebGPU backend reuses stores every non-empty constant in the PTE's named-data map with `offset == UINT64_MAX` and a `named_key`, rather than inline in the VK00 blob. `WebGPUGraph::build` previously handled only inline constants, so a delegated op's constant weights were never uploaded and the op produced all zeros. `build` now also fetches named-data constants via `NamedDataMap::get_data`, mirroring the path `VulkanBackend` already uses. `aten.add` was unaffected since it has no constant tensors; the first consumer is the `rms_norm` op in the child diff. ghstack-source-id: 389182397 exported-using-ghexport Differential Revision: D107288998
meta-codesync
Bot
merged commit 8da7936
into
gh/JulianCloudNTH/7/base
170 of 176 checks passed
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 4, 2026
The Vulkan serializer that the WebGPU backend reuses stores every non-empty constant in the PTE's named-data map with `offset == UINT64_MAX` and a `named_key`, rather than inline in the VK00 blob. `WebGPUGraph::build` previously handled only inline constants, so a delegated op's constant weights were never uploaded and the op produced all zeros. `build` now also fetches named-data constants via `NamedDataMap::get_data`, mirroring the path `VulkanBackend` already uses. `aten.add` was unaffected since it has no constant tensors; the first consumer is the `rms_norm` op in the child diff. Differential Revision: [D107288998](https://our.internmc.facebook.com/intern/diff/D107288998/) ghstack-source-id: 389182397 Pull-Request: #19962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The Vulkan serializer that the WebGPU backend reuses stores every non-empty constant in the PTE's named-data map with
offset == UINT64_MAXand anamed_key, rather than inline in the VK00 blob.WebGPUGraph::buildpreviously handled only inline constants, so a delegated op's constant weights were never uploaded and the op produced all zeros.buildnow also fetches named-data constants viaNamedDataMap::get_data, mirroring the pathVulkanBackendalready uses.aten.addwas unaffected since it has no constant tensors; the first consumer is therms_normop in the child diff.Differential Revision: D107288998