[ExecuTorch][WebGPU] Add rms_norm op#19963
Merged
meta-codesync[bot] merged 2 commits intoJun 4, 2026
Merged
Conversation
JulianCloudNTH
requested review from
kirklandsign and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19963
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 91256e5 with merge base 915a82d ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
SS-JIA
approved these changes
Jun 3, 2026
JulianCloudNTH
added a commit
to JulianCloudNTH/executorch
that referenced
this pull request
Jun 3, 2026
Summary: Adds the `et_vk.rms_norm.default` operator to the WebGPU backend: a WGSL compute shader using a cooperative tree reduction, one workgroup per row. The shader mirrors the Vulkan implementation (`backends/vulkan/runtime/graph/ops/impl/RmsNorm.cpp`, `backends/vulkan/runtime/graph/ops/glsl/rms_norm_buffer.glsl`); indexing assumes contiguous fp32 inputs. The handler fails loud (throws, mirroring Vulkan's `VK_CHECK_COND`) on invalid shape/dtype/dispatch-limit conditions, and defaults `eps` to the float32 machine epsilon. The weight constant is uploaded via the named-data path added in the parent diff. ghstack-source-id: 389206169 exported-using-ghexport Reviewed By: SS-JIA Differential Revision: D106887028
JulianCloudNTH
added a commit
to JulianCloudNTH/executorch
that referenced
this pull request
Jun 3, 2026
Summary: Pull Request resolved: pytorch#19963 Adds the `et_vk.rms_norm.default` operator to the WebGPU backend: a WGSL compute shader using a cooperative tree reduction, one workgroup per row. The shader mirrors the Vulkan implementation (`backends/vulkan/runtime/graph/ops/impl/RmsNorm.cpp`, `backends/vulkan/runtime/graph/ops/glsl/rms_norm_buffer.glsl`); indexing assumes contiguous fp32 inputs. The handler fails loud (throws, mirroring Vulkan's `VK_CHECK_COND`) on invalid shape/dtype/dispatch-limit conditions, and defaults `eps` to the float32 machine epsilon. The weight constant is uploaded via the named-data path added in the parent diff. ghstack-source-id: 389206169 exported-using-ghexport Differential Revision: D106887028
meta-codesync
Bot
merged commit 7be77e7
into
gh/JulianCloudNTH/8/base
172 of 184 checks passed
JulianCloudNTH
added a commit
that referenced
this pull request
Jun 4, 2026
Pull Request resolved: #19963 Adds the `et_vk.rms_norm.default` operator to the WebGPU backend: a WGSL compute shader using a cooperative tree reduction, one workgroup per row. The shader mirrors the Vulkan implementation (`backends/vulkan/runtime/graph/ops/impl/RmsNorm.cpp`, `backends/vulkan/runtime/graph/ops/glsl/rms_norm_buffer.glsl`); indexing assumes contiguous fp32 inputs. The handler fails loud (throws, mirroring Vulkan's `VK_CHECK_COND`) on invalid shape/dtype/dispatch-limit conditions, and defaults `eps` to the float32 machine epsilon. The weight constant is uploaded via the named-data path added in the parent diff. ghstack-source-id: 389206169 @exported-using-ghexport Differential Revision: [D106887028](https://our.internmc.facebook.com/intern/diff/D106887028/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds the
et_vk.rms_norm.defaultoperator to the WebGPU backend: a WGSL compute shader using a cooperative tree reduction, one workgroup per row. The shader mirrors the Vulkan implementation (backends/vulkan/runtime/graph/ops/impl/RmsNorm.cpp,backends/vulkan/runtime/graph/ops/glsl/rms_norm_buffer.glsl); indexing assumes contiguous fp32 inputs. The handler fails loud (throws, mirroring Vulkan'sVK_CHECK_COND) on invalid shape/dtype/dispatch-limit conditions, and defaultsepsto the float32 machine epsilon.The weight constant is uploaded via the named-data path added in the parent diff.
@exported-using-ghexport
Differential Revision: D106887028
Differential Revision: D106887028