Qualcomm AI Engine Direct - Remove C++ designated initializers for Windows MSVC

[zhaoxul-qti]

Summary

This PR is a follow-up to #19686

Due to the changes in #19621, additional adjustments are required for Windows MSVC compatibility. This PR removes remaining C++ designated initializers and aligns the implementation accordingly.

• Designated initializers for C++ aggregates were standardized in C++20.
• GCC and Clang have supported them as a C++11/14/17 extension — they silently accept the syntax even when compiling in -std=c++17 mode.
• MSVC is strictly conformant: it only accepts designated initializers when /std:c++20 (or /std:c++latest) is active.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20441

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ You can merge normally! (1 Unrelated Failure), 2 Unclassified Failures

As of commit a55d31d with merge base 60b1351 ():

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

• Build Aarch64 Linux Wheels / pytorch/executorch / build-wheel-py3_10-cpu-aarch64 (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  /__w/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/inmemoryfs/inmemory_filesystem.cpp:722:48: error: ‘inmemoryfs::InMemoryFileSystem::InMemoryNode::Kind’ has not been declared
• Build Aarch64 Linux Wheels / pytorch/executorch / upload / upload-wheel-py3_10-cpu-aarch64 (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  Unable to download artifact(s): Artifact not found for name: pytorch_executorch__3.10_cpu_aarch64

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[zhaoxul-qti]

Hi @GregoryComer and @psiddh,
This PR is required to support build QNN ExecuTorch with Windows MSVC.

Thanks for the review!

[meta-codesync]

@psiddh has imported this pull request. If you are a Meta employee, you can view this in D109863039.

[zhaoxul-qti]

Hi @psiddh,
Thanks for the review!

It appears that the test-llama-runner-qnn-linux job encountered an error in CI. After taking a look, it seems to be caused by an unstable connection.
Would you mind retriggering the CI to see if the issue persists?
Thanks!

[shewu-quic]

Hi @psiddh ,
This PR is to fix qualcomm windows build failure due to the PR

[shewu-quic]

Don't worry. We will add a test case for qualcomm windows build to avoid this situation in the community

[psiddh]

Do yo know why pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (pull_request)Failing after 33m is failing ? I assume it is unrelated

[shewu-quic]

Do yo know why pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (pull_request)Failing after 33m is failing ? I assume it is unrelated

I think it is unrelated.