Skip to content

Point VGF tests at model-converter 0.9.0#20520

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
rascani:export-D109721412
Jun 26, 2026
Merged

Point VGF tests at model-converter 0.9.0#20520
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
rascani:export-D109721412

Conversation

@rascani

@rascani rascani commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary: tosa_tools v2026.5.0 emits TOSA SerLib 2026.5.0 flatbuffers, which the model-converter v0.8.0 cannot deserialize (ERROR: Tosa file created with newer SerLib version 2026.5.0 is not compatible with current version 1.1.0d). Repoint the Arm VGF test MODEL_CONVERTER_PATH to ai-ml-sdk-model-converter/0.9.0, which supports the new spec. Applied to both the fbcode and xplat mirrors.

Differential Revision: D109721412

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Summary: `tosa_tools` v2026.5.0 emits TOSA SerLib 2026.5.0 flatbuffers, which the model-converter v0.8.0 cannot deserialize (`ERROR: Tosa file created with newer SerLib version 2026.5.0 is not compatible with current version 1.1.0d`). Repoint the Arm VGF test `MODEL_CONVERTER_PATH` to `ai-ml-sdk-model-converter/0.9.0`, which supports the new spec. Applied to both the fbcode and xplat mirrors.

Differential Revision: D109721412
@rascani
rascani requested a review from digantdesai as a code owner June 25, 2026 17:42
@pytorch-bot

pytorch-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20520

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 5 Pending, 2 Unrelated Failures

As of commit 6939047 with merge base a0a730a (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2026
@meta-codesync

meta-codesync Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109721412.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 25, 2026

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync
meta-codesync Bot merged commit c7d2542 into pytorch:main Jun 26, 2026
654 of 675 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants